Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simulator] quick fix - send opposite budget to the result #1614

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Dec 18, 2024

fix #1613
We weren't sending the opposite budget to the result page from the simulation one, resulting into a full budget on one token.

Test case :

  • Go to simulator
  • Select concentrated
  • Fill a budget
  • Click on "Start Simulation"
  • Now both budget are filled from the start (instead of only one in prod)

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: 792b8d5
Status: ✅  Deploy successful!
Preview URL: https://4036f06e.carbon-app-blast.pages.dev
Branch Preview URL: https://issue--1613.carbon-app-blast.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 792b8d5
Status: ✅  Deploy successful!
Preview URL: https://7623228c.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1613.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 792b8d5
Status: ✅  Deploy successful!
Preview URL: https://8539c37a.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1613.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 792b8d5
Status: ✅  Deploy successful!
Preview URL: https://147d50df.carbon-app-celo.pages.dev
Branch Preview URL: https://issue--1613.carbon-app-celo.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf merged commit e040682 into main Dec 18, 2024
4 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1613 branch December 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Simulator] Budget is not stored in the URL
3 participants